search

JezerM / nody-greeter

LightDM greeter that allows to create wonderful themes with web technologies. Made in Node.js
https://web-greeter-page.vercel.app
GNU General Public License v3.0
125 stars 8 forks source link

Installation Instruction Improvement - TypeScript Compile #5

Closed mshernandez5 closed 2 years ago

mshernandez5 commented 2 years ago

Hello!

I was building this project earlier and realized that the TypeScript compiler is never automatically run during the process, which obviously causes issues during the node make build step. This is not a huge issue by any means but can save a few people from a little confusion.

It appears that tsc is invoked with the npm run build target but this was changed in favor of node make build with ed648f4 (which runs the build script indirectly but no longer with the tsc step defined in package.json). Adding a npx tsc step to the installation or otherwise making it so this gets run could be helpful.

JezerM commented 2 years ago

Oh, sure, I forgot about tsc. I'll fix that.

JezerM commented 2 years ago

npx tsc step added to README :D