JezerM / web-greeter

A modern, visually appealing greeter for LightDM.
https://jezerm.github.io/web-greeter-page/
GNU General Public License v3.0
204 stars 10 forks source link

An suggestion for having all your themes in one place #24

Closed austinrojers closed 2 years ago

austinrojers commented 2 years ago

Description of feature

Hey there @JezerM, I wondered if you could add glorious, aether, and litarvan themes here: https://github.com/JezerM/web-greeter/tree/master/themes, instead of someone would have to clone your fork and copy it to /usr/share/web-greeter/themes/?

In the case of litarvan you also have to build it first.

JezerM commented 2 years ago

Hi~ I think that's not possible.

web-greeter should only contain its own themes. Third party themes are needed to be manually installed because of these reasons:

Unless the themes are completely abandoned and I decided to work on them with lots of changes and improvements, they won't be included as part of web-greeter.

The most I could do it's to reference them inside the README.

austinrojers commented 2 years ago

Oh, I didn't know that. Sorry for my ignorance.

JezerM commented 2 years ago

No problem~

austinrojers commented 2 years ago

One more suggestion from my side is, you could edit the readme file of your theme forks according to your installation instructions? The instructions there are for the original project and could be a little confusing.