Closed Nothehi closed 1 year ago
Thank you so much! Looks good, I think there's a few small things you missed so I left a few comments.
Could you also translate the following:
If you would like to be credited, could you also provide a statement like this in Persian too: "Translated by Hossein Nodehi". And would you like me to make that link to your website, https://nothehi.ir ?
Ok, I added a pageData
to make-html.js
and modified the title and description, but the text on these two images doesn't seem to be translatable!
Ah, thanks for doing that! I just meant that you can send the translations here and I could do a follow up change to include those, but easier to have the file updated too. For those other sections, I realized I forgot to translate them earlier, so I'm currently making tweaks to the site so they're translated. So if you can just send me some example text I can update that.
I also left some comments in the files itself, could you take a look at those, and either update the file or reply to the comment saying no update is needed?
Great,
What kind of example text do you need? If you wanna the translations of time
, value
, frequency
, and amplitude
, I've added them at the end of this comment. Also, can you give me the address of the files that you commented on? I didn't see your comments!
زمان
مقدار
فرکانس
دامنه
Thanks! Would I write it time = 10
as زمان = 10
? And for frequency, is what Google translates as فرکانس = 10 هرتز
correct?
And you can see the comments I left here: https://github.com/Jezzamonn/fourier/pull/51/files
And you can see the comments I left here: #51 (files)
I suspect you may have written comments as part of a review but not actually submit the review. I don't see anything either.
Thanks! Would I write it
time = 10
asزمان = 10
? And for frequency, is what Google translates asفرکانس = 10 هرتز
correct?And you can see the comments I left here: https://github.com/Jezzamonn/fourier/pull/51/files
Thanks, yeah, that translation is correct. and for your comment, I still don't see anything, I guess as @waldyrious mentioned probably you haven't submitted comments!
Thank you for this awesome article, I appreciate it.
I translated this into Persian for Iranians and other Farsi speakers. Our country is going through a difficult time, I hope I have helped with this translation.