search

Jguer / go-alpm

Go bindings to Pacman's libalpm
MIT License
45 stars 14 forks source link

Update function name for next pacman release #31

Closed Morganamilo closed 5 years ago

Morganamilo commented 5 years ago

I'm not quite sure on the function name on the go side. We follow go's conventions and just use .Foo instead of .GetFoo so SyncNewVersion makes sense.

However the name might suggest that it actually syncs the new version, where it actually just gets the new package data from the database. This is now apparent from the c function name but not from the go function name

Also the function implementation has slightly changed. The point of the rename is to be a breaking change, making it obvious for downstream users to know there was a change. So would it also back sense for us to rename it too?

It's not that big a deal though, I'm fine with it as if there's no better name suggested. Just worth mentioning.

Jguer commented 5 years ago

I think we don't need to rename it as well, from a naming convention viewpoint alpm was breaking C's convention of 'object' versus procedure. From that viewpoint I don't feel the need to rename the function. For the breaking change side of the argument, I also think since the new go modules focuses on versioning, we just bump the major version.