Option --noupgrademenu is not honored

[dalto8]

Affected Version

yay v12.0.3 - libalpm v13.0.2

Describe the bug

The option --noupgrademenu seems to be ignored. Even when using that option it still presents the upgrade menu asking which packages to ignore.

Reproduction Steps

1. run yay -Syu --noupgrademenu
2. The upgrade menu will be presented

Expected behavior

The upgrade menu should not be presented.

Output

>> yay --noupgrademenu --repo -Syu                                                                                                           [1]
:: Synchronizing package databases...
 zfs-linux-lts is up to date
 zfs-linux is up to date
 core is up to date
 extra is up to date
 community is up to date
 multilib is up to date
 archzfs is up to date
:: Searching databases for updates...
:: 33 Packages to upgrade.
33  zfs-linux-lts/linux-lts            6.1.20-1                   -> 6.1.22-1
32  zfs-linux-lts/linux-lts-headers    6.1.20-1                   -> 6.1.22-1
31  zfs-linux/linux                    6.2.7.arch1-1              -> 6.2.9.arch1-1
30  zfs-linux/linux-headers            6.2.7.arch1-1              -> 6.2.9.arch1-1
29  core/coreutils                     9.2-2                      -> 9.2-3
28  core/gettext                       0.21.1-4                   -> 0.21.1-5
27  core/hwdata                        0.368-1                    -> 0.369-1
26  core/libnghttp2                    1.52.0-1                   -> 1.52.0-2
25  core/systemd                       253.2-1                    -> 253.3-1
24  core/systemd-libs                  253.2-1                    -> 253.3-1
23  core/systemd-sysvcompat            253.2-1                    -> 253.3-1
22  core/texinfo                       7.0.2-2                    -> 7.0.3-1
21  extra/adobe-source-code-pro-fonts  2.038ro+1.058it+1.018var-1 -> 2.040u+1.060i+1.024vf-1
20  extra/chromium                     111.0.5563.146-1           -> 112.0.5615.49-1
19  extra/fuse-common                  3.14.0-1                   -> 3.14.1-1
18  extra/fuse3                        3.14.0-1                   -> 3.14.1-1
17  extra/hplip                        1:3.22.10-3                -> 1:3.23.3-1
16  extra/libva-mesa-driver            23.0.1-1                   -> 23.0.1-2
15  extra/mesa                         23.0.1-1                   -> 23.0.1-2
14  extra/mesa-vdpau                   23.0.1-1                   -> 23.0.1-2
13  extra/ndctl                        76-1                       -> 76.1-1
12  extra/vulkan-radeon                23.0.1-1                   -> 23.0.1-2
11  extra/xf86-input-libinput          1.2.1-1                    -> 1.3.0-1
10  community/borgmatic                1.7.10-1                   -> 1.7.11-1
 9  community/openimageio              2.4.9.0-2                  -> 2.4.10.0-1
 8  community/pacman-contrib           1.8.2-1                    -> 1.9.0-1
 7  community/python-feedparser        6.0.10-1                   -> 6.0.10-2
 6  community/rubberband               3.1.2-1                    -> 3.2.1-1
 5  multilib/lib32-mesa                23.0.1-1                   -> 23.0.1-2
 4  multilib/lib32-systemd             253.2-1                    -> 253.3-1
 3  multilib/lib32-vulkan-radeon       23.0.1-1                   -> 23.0.1-2
 2  archzfs/zfs-linux                  2.1.9_6.2.7.arch1.1-1      -> 2.1.9_6.2.9.arch1.1-1
 1  archzfs/zfs-linux-lts              2.1.9_6.1.20.1-1           -> 2.1.9_6.1.22.1-1
==> Packages to exclude: (eg: "1 2 3", "1-3", "^4" or repo name)
 -> Excluding packages may cause partial upgrades and break systems
==> 

[Jguer]

Can you try --nocombinedupgrade in yay-git and confirm if it does what you expect?

[dalto8]

The results are quite interesting after testing yay-git.

yay -Su --nocombinedupgrade - Shows the upgrade menu and is combined

yay -Su --nocombinedupgrade --noupgrademenu - Shows the upgrade menu and is combined

yay --nocombinedupgrade - Does not show the upgrade menu

yay --nocombinedupgrade --upgrademenu - Does not show the upgrade menu

[Jguer]

the --upgrademenu flag is just dangling currently and I think it can be unified with --combinedupgrade.

It's true yay -Su is not taking care of either --nocombinedupgrade --noupgrademenu

Currently these 2 flags generate 4 ramifications of install logic which complexifies flows quite a bit.

My proposal would be:

--nocombinedupgrade does not show the upgrade menu for AUR and Repo and is "not combined" (repo and AUR packages are always installed separately anyway, but for visual purposes we can call it the "not combined" experience)

--combinedupgrade shows the upgrade menu for AUR and Repo and the menu is combined

[dalto8]

That sounds reasonable to me.

[jdholtz]

Should this issue be closed? --noupgrademenu (or --upgrademenu) is no longer a valid flag and --combinedupgrade seems to do what @Jguer suggested in https://github.com/Jguer/yay/issues/2090#issuecomment-1500062965.