`yay -Y --gendb`'s `PKGBUILD` download counter counts `0` at counts from 300 onwards.

dreirund commented 10 months ago

Affected Version

yay -V: yay v12.1.3 - libalpm v13.0.2

Describe the bug

When I do yay -Y --gendb, the terminal output is:

[...]
:: (295/619) Downloaded PKGBUILD: detex-git
:: (296/619) Downloaded PKGBUILD: perl-gis-distance-git
:: (297/619) Downloaded PKGBUILD: dmidiplayer
:: (298/619) Downloaded PKGBUILD: vte-legacy
:: (299/619) Downloaded PKGBUILD: marble-maps-googlemaps-git
:: (0/619) Downloaded PKGBUILD: texlive-fonts-emerald
:: (0/619) Downloaded PKGBUILD: kibot-git
:: (0/619) Downloaded PKGBUILD: autopanovideopro
:: (0/619) Downloaded PKGBUILD: spflashtool-bin
:: (0/619) Downloaded PKGBUILD: python2-pillow
[...]

The repeated 0 here is strange.

Reproduction Steps

Have my system (I suppose at least 300 AUR packages installed).
Run yay -Y --gendb.
Observe that yay is counting downloaded PKGBUILDs, but counts 0 from 300 onwards.

Expected behavior

Count correctly even for downloaded PKGBUILD number ≥ 300.

Output

yay -Pg:

{
    "aururl": "https://aur.archlinux.org",
    "aurrpcurl": "https://aur.archlinux.org/rpc?",
    "buildDir": "/tmp/makepkg/yay",
    "editor": "",
    "editorflags": "",
    "makepkgbin": "makepkg",
    "makepkgconf": "",
    "pacmanbin": "pacman",
    "pacmanconf": "/etc/pacman.conf",
    "redownload": "no",
    "answerclean": "",
    "answerdiff": "",
    "answeredit": "",
    "answerupgrade": "",
    "gitbin": "git",
    "gpgbin": "gpg",
    "gpgflags": "",
    "mflags": "",
    "sortby": "name",
    "searchby": "name-desc",
    "gitflags": "",
    "removemake": "yes",
    "sudobin": "sudo",
    "sudoflags": "",
    "version": "12.1.3",
    "requestsplitn": 150,
    "completionrefreshtime": 7,
    "maxconcurrentdownloads": 0,
    "bottomup": true,
    "sudoloop": false,
    "timeupdate": false,
    "devel": true,
    "cleanAfter": false,
    "provides": true,
    "pgpfetch": true,
    "cleanmenu": true,
    "diffmenu": true,
    "editmenu": false,
    "combinedupgrade": true,
    "useask": false,
    "batchinstall": false,
    "singlelineresults": false,
    "separatesources": true,
    "debug": false,
    "rpc": true,
    "doubleconfirm": true,
    "rebuild": "no"
}

Full output of yay -Y --gendb: yay-Y-gendb.terminallog.txt.

Regards!

jdholtz commented 9 months ago

Is this issue fixed now that #2313 is merged?

dreirund commented 9 months ago

Is this issue fixed now that #2313 is merged?

yay version 12.1.3, which is the lastest release available and the version I commented in the original report, still has the issue, but now I see with slightly larger cutoff number of 302 and a 0 in between:

[...]
:: (297/733) Downloaded PKGBUILD: qmk-hid
:: (298/733) Downloaded PKGBUILD: mpv-uosc
:: (299/733) Downloaded PKGBUILD: exact-audio-copy
:: (300/733) Downloaded PKGBUILD: obsidian-export
:: (301/733) Downloaded PKGBUILD: pcf-unifont
:: (0/733) Downloaded PKGBUILD: samsung-unified-driver
:: (302/733) Downloaded PKGBUILD: latex-saxpsa-ok
:: (0/733) Downloaded PKGBUILD: svg2tikz-git
:: (0/733) Downloaded PKGBUILD: qmediathekview-git
:: (0/733) Downloaded PKGBUILD: riven
:: (0/733) Downloaded PKGBUILD: xnec2c-git
:: (0/733) Downloaded PKGBUILD: polenum
[...]

Regards!

jdholtz commented 9 months ago

yay version 12.1.3, which is the lastest release available

The PR was just merged, so you would need to test it by building yay from source to see if it is still present.

Jguer / yay