search

Jh123x / pe

0 stars 0 forks source link

The number of MCs for a mod is different from the number of mcs shown on the card #12

Open Jh123x opened 3 years ago

Jh123x commented 3 years ago

The number of MCs for a mod is different from the number of mcs shown on the card

image.png

nus-se-bot commented 3 years ago

Team's Response

Overflow of large numbers is an inherited behavior of Java. This is not expected user behavior and no student can ever accumulate such an unrealistic amount of MCs (only 160 is required for a single major).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In that case it should be on the team to restrict the number of mcs that is loaded and create a new file containing default values as per the implementation in addressbook3.

image.png

If 160 MCs is required for a single major, the team should restrict the maximum number of MCs to 160 for 1 module and use the AppUtil to check if the value in the json files are valid.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: image.png

As per the image above it will cause more than a minor inconvenience for the user as it will result in other commands functioning incorrectly. Especially when combined with the UI which causes the user not to be able to track the amount of MCs properly.