search

Jhanay / libyuv

Automatically exported from code.google.com/p/libyuv
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

use_sysroot=0 #542

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Linux Arm is broken due to use_sysroot=0 in libyuv.gyp

Some options:
1. Remove the variable.  It affects a library used by webrtc but not libyuv.
Make sure that the runhooks for libyuv correctly install the sysroots

2. set "use_sysroot=0" in gyp_libyuv where it won't effect the chromium build.

Original issue reported on code.google.com by fbarch...@google.com on 7 Jan 2016 at 7:50

GoogleCodeExporter commented 8 years ago 
in r1563
GYP_DEFINES="target_arch=x86" ./gyp_libyuv libyuv_test.gyp

Updating projects from gyp files...
gyp: Undefined variable sysroot in libyuv_test.gyp

    'variables': {
      # Disable use of sysroot for Linux. It's enabled by default in Chromium,
      # but it currently lacks the libudev-dev package.
      # TODO(kjellander): Remove when crbug.com/561584 is fixed.
      'conditions': [
         ['target_arch=="ia32" or target_arch=="x64"', {
           'use_sysroot': 0,
         }, {
           'use_sysroot%': 1,
         }],
       ],
    },
    'use_sysroot%': '<(use_sysroot)',

Original comment by fbarch...@google.com on 11 Jan 2016 at 6:50

GoogleCodeExporter commented 8 years ago

Original comment by fbarch...@google.com on 11 Jan 2016 at 6:50

GoogleCodeExporter commented 8 years ago 
The following revision refers to this bug:
  https://chromium.googlesource.com/libyuv/libyuv.git/+/0e462e6f450b9248a83feee50871e1ad76d317c3

commit 0e462e6f450b9248a83feee50871e1ad76d317c3
Author: Frank Barchard <fbarchard@google.com>
Date: Mon Jan 11 22:57:50 2016

Remove use_sysroot=0

use_sysroot=0 is required for webrtc on linux intel builds, but
libyuv doesnt use the affected libraries, so removing this.

R=harryjin@google.com, sbc@chromium.org
BUG=libyuv:534,libyuv:542

Review URL: https://codereview.chromium.org/1566303002 .

[modify] http://crrev.com/0e462e6f450b9248a83feee50871e1ad76d317c3/libyuv.gyp
[modify] 
http://crrev.com/0e462e6f450b9248a83feee50871e1ad76d317c3/source/scale_win.cc
[modify] 
http://crrev.com/0e462e6f450b9248a83feee50871e1ad76d317c3/unit_test/convert_test
.cc

Original comment by bugdroid1@chromium.org on 11 Jan 2016 at 10:58

GoogleCodeExporter commented 8 years ago 
Mark this as fixed now? Or did you have issues running gyp_libyuv?

Original comment by kjellan...@google.com on 12 Jan 2016 at 6:16

GoogleCodeExporter commented 8 years ago

Original comment by fbarch...@google.com on 13 Jan 2016 at 1:18