JhohannesK / TipoHiZ

A typing website made for everyone
https://tipohiz.vercel.app/
GNU General Public License v3.0
16 stars 33 forks source link

added a new cyberpunk theme #102

Closed jatinn-sw closed 1 day ago

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tipohiz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 11:43am
JhohannesK commented 2 days ago

No images to show how it looks like?

or it's still in progress?

jatinn-sw commented 2 days ago

oh yes, this is a preview of how it might/will look like

image

jatinn-sw commented 2 days ago

this might not be 100% accurate but it is very much close

JhohannesK commented 2 days ago

oh yes, this is a preview of how it might/will look like

image

colors doesn't look cool to me though.. aside that, you have added to the list themes to selected by users.

you can follow #92 to see how he did his.

jatinn-sw commented 2 days ago

well, am kind of a newbie, one of my class-mate/roomie helped me with this so... apologies if it is not cool

JhohannesK commented 2 days ago

Sure..it's fine

So after adding the colors to the css file, you need to add the class name you used in the css file to list of themes.

Checkout the expo/theme-choose.tsx file.

jatinn-sw commented 2 days ago

a quick question, u just need me to add the name to the list of themes in the expo/theme-choose.tsx file right? or am I missing something?

jatinn-sw commented 2 days ago

ohh got it, hold on ive been bangin my head so bad

jatinn-sw commented 2 days ago

yes i got it :) now i can change the color scheme if you'd like lmao

JhohannesK commented 2 days ago

image

The background makes the text not visible enough. Can you look that quickly?.

JhohannesK commented 2 days ago

image This is what I see for cyberpunk now

jatinn-sw commented 2 days ago

hold on, still working on it ama get back to you when its done :)

jatinn-sw commented 2 days ago

ahh, am finally done mate/ after grueling around for an hour am done
TT

image

jatinn-sw commented 2 days ago

not bad for a newbie tho hehe

JhohannesK commented 1 day ago

There's a bit of a minor issue though...

you need to add cyberpunk to the themes array in app/layout.tsx also. else, it causes a bug as mentioned in #104.

JhohannesK commented 1 day ago

Closing this..there's an issue created for bug observerd

jatinn-sw commented 1 day ago

wait so, is that a bad thing?

jatinn-sw commented 1 day ago

i mean, it didnt show me any bugs or conflicts when i was adding the theme

JhohannesK commented 1 day ago

i mean, it didnt show me any bugs or conflicts when i was adding the theme

Did you run to test?