Closed chiragchhatrala closed 2 days ago
The changes in this pull request enhance the MatrixInput.vue
, CheckboxIcon.vue
, RadioButtonIcon.vue
, ToggleSwitchInput.vue
, UserFormRequest.php
, OpenFormField.vue
, and FieldOptions.vue
components. The MatrixInput.vue
component improves the handling of the disabled
state with updated template bindings and modified interaction logic. The CheckboxIcon.vue
and RadioButtonIcon.vue
components restructure their templates to use separate Icon
components for checked and unchecked states. The ToggleSwitchInput.vue
component replaces <v-switch>
with a custom <UToggle>
component. Additionally, validation rules in UserFormRequest.php
are simplified, and character limit handling is enhanced in OpenFormField.vue
and FieldOptions.vue
.
File | Change Summary |
---|---|
client/components/forms/MatrixInput.vue | Updated template for conditional class bindings to reflect disabled state; modified onSelect method to prevent interactions when disabled. |
client/components/forms/components/CheckboxIcon.vue | Restructured template to use two separate Icon components for checked and unchecked states; modified icon naming convention and color handling. |
client/components/forms/components/RadioButtonIcon.vue | Restructured template to use two separate Icon components for checked and unchecked states; simplified logic for rendering icons. |
client/components/forms/ToggleSwitchInput.vue | Replaced <v-switch> with a custom <UToggle> component; added label slot and updated help section. |
api/app/Http/Requests/UserFormRequest.php | Updated validation rules for max_char_limit to remove maximum limit; simplified associated validation messages. |
client/components/open/forms/OpenFormField.vue | Changed default value of maxCharLimit from 2000 to null when field.max_char_limit is not defined; minor CSS adjustment for button spacing. |
client/components/open/forms/fields/components/FieldOptions.vue | Added method onFieldMaxCharLimitChange for handling max character limit updates; modified template for character limit display. |
client/components/open/forms/OpenForm.vue | Updated logic in handleUrlPrefill and handleDefaultPrefill methods for improved handling of prefill values and error management. |
client/components/open/forms/components/FormUrlPrefill.vue | Enhanced preFillUrl computed property to handle complex data structures in URL parameters. |
MatrixInput.vue
component, specifically addressing structural changes and lifecycle management, which are relevant to the enhancements made in the main PR regarding the disabled
state handling.layout_rtl
in the UserFormRequest
class, which could be relevant as it may affect how the MatrixInput.vue
component is rendered in right-to-left layouts, potentially interacting with the disabled
state handling in the main PR.In a garden where bunnies play,
A matrix of choices brightens the day.
With a flick of a switch, the cells turn gray,
No clicks allowed when the game’s gone astray.
Hopping along, we’ll keep it at bay! 🐰✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Bug Fixes