JhumanJ / OpnForm

Beautiful Open-Source Form Builder
https://opnform.com
GNU Affero General Public License v3.0
2.26k stars 303 forks source link

Matrix Improvements #606

Closed chiragchhatrala closed 2 days ago

chiragchhatrala commented 3 weeks ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

Walkthrough

The changes in this pull request enhance the MatrixInput.vue, CheckboxIcon.vue, RadioButtonIcon.vue, ToggleSwitchInput.vue, UserFormRequest.php, OpenFormField.vue, and FieldOptions.vue components. The MatrixInput.vue component improves the handling of the disabled state with updated template bindings and modified interaction logic. The CheckboxIcon.vue and RadioButtonIcon.vue components restructure their templates to use separate Icon components for checked and unchecked states. The ToggleSwitchInput.vue component replaces <v-switch> with a custom <UToggle> component. Additionally, validation rules in UserFormRequest.php are simplified, and character limit handling is enhanced in OpenFormField.vue and FieldOptions.vue.

Changes

File Change Summary
client/components/forms/MatrixInput.vue Updated template for conditional class bindings to reflect disabled state; modified onSelect method to prevent interactions when disabled.
client/components/forms/components/CheckboxIcon.vue Restructured template to use two separate Icon components for checked and unchecked states; modified icon naming convention and color handling.
client/components/forms/components/RadioButtonIcon.vue Restructured template to use two separate Icon components for checked and unchecked states; simplified logic for rendering icons.
client/components/forms/ToggleSwitchInput.vue Replaced <v-switch> with a custom <UToggle> component; added label slot and updated help section.
api/app/Http/Requests/UserFormRequest.php Updated validation rules for max_char_limit to remove maximum limit; simplified associated validation messages.
client/components/open/forms/OpenFormField.vue Changed default value of maxCharLimit from 2000 to null when field.max_char_limit is not defined; minor CSS adjustment for button spacing.
client/components/open/forms/fields/components/FieldOptions.vue Added method onFieldMaxCharLimitChange for handling max character limit updates; modified template for character limit display.
client/components/open/forms/OpenForm.vue Updated logic in handleUrlPrefill and handleDefaultPrefill methods for improved handling of prefill values and error management.
client/components/open/forms/components/FormUrlPrefill.vue Enhanced preFillUrl computed property to handle complex data structures in URL parameters.

Possibly related PRs

Poem

In a garden where bunnies play,
A matrix of choices brightens the day.
With a flick of a switch, the cells turn gray,
No clicks allowed when the game’s gone astray.
Hopping along, we’ll keep it at bay! 🐰✨


📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 6e4b1cc2ab5940b004055ee95b40d927a9f8256c and b0713462507c250900be5aaf00438e61d1633c92.
📒 Files selected for processing (2) * `api/app/Http/Requests/UserFormRequest.php` (2 hunks) * `client/components/open/forms/OpenForm.vue` (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (2) * api/app/Http/Requests/UserFormRequest.php * client/components/open/forms/OpenForm.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.