Closed chiragchhatrala closed 4 days ago
The pull request introduces enhancements to various form input components by updating the class bindings for their disabled states to include dark mode styles. This ensures that when the components are disabled, they visually respond appropriately in dark mode by applying a darker background color. The changes span multiple components, including CodeInput
, DateInput
, FlatSelectInput
, MentionInput
, PhoneInput
, RichTextAreaInput
, SignatureInput
, TextAreaInput
, TextInput
, and VSelect
, while maintaining their overall functionality and structure.
File Path | Change Summary |
---|---|
client/components/forms/CodeInput.client.vue |
Updated class binding for disabled state to include dark:!bg-gray-800 . |
client/components/forms/DateInput.vue |
Modified inputClasses for dark mode disabled state; added error handling in formattedDate . |
client/components/forms/FlatSelectInput.vue |
Updated class binding for disabled state to include dark:!bg-gray-800 . |
client/components/forms/MentionInput.vue |
Altered class binding for disabled state to include dark:!bg-gray-800 . |
client/components/forms/PhoneInput.vue |
Updated class binding for disabled state to include dark:!bg-gray-800 . |
client/components/forms/RichTextAreaInput.client.vue |
Updated class binding for disabled state to include dark:!bg-gray-800 ; added new props. |
client/components/forms/SignatureInput.vue |
Updated class binding for disabled state to include dark:!bg-gray-800 . |
client/components/forms/TextAreaInput.vue |
Modified class binding for disabled state to include dark:!bg-gray-800 ; added new prop. |
client/components/forms/TextInput.vue |
Updated class binding for disabled state to include dark:!bg-gray-800 . |
client/components/forms/components/VSelect.vue |
Updated class binding for disabled state to include dark:!bg-gray-800 . |
Objective | Addressed | Explanation |
---|---|---|
Dark styles for disabled input fields (#614) | ✅ |
SelectInput.vue
include changes to CodeInput
styles, relevant to visual feedback for disabled states.VSelect.vue
involve updates to the disabled state class binding, similar to enhancements in CodeInput.client.vue
.PhoneInput.vue
reflect similar enhancements in visual feedback for disabled inputs as seen in CodeInput.client.vue
.🐇 In the dark, where inputs lay,
A brighter hue will save the day.
With shades of gray, we now can see,
Disabled fields, so clear and free!
A hop, a skip, a joyful cheer,
For dark mode's grace, we hold so dear! 🌙
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Fixed #614
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Documentation
These changes collectively enhance user interface consistency and accessibility across the application.