search

Ji-Zhang / datacleanbot

MIT License
8 stars 1 forks source link

Missing unit tests #8

Open kellieotto opened 5 years ago

kellieotto commented 5 years ago

This issue is part of your JOSS review.

For JOSS, you are required to have automated testing. I'd like to see unit tests for each function. Once those are in place, I recommend setting up Travis CI.

Ji-Zhang commented 5 years ago

Sorry I was not aware of the unit test requirement. My intention was to test the package by these two examples and they work nicely so far. I will implement the tests progressively but it may take some time.

kellieotto commented 5 years ago

Sounds good. Please drop me a line when tests are in place so I can take a look.

Ji-Zhang commented 5 years ago

Will do :)

kthyng commented 4 years ago

Hi @kellieotto and @Ji-Zhang — here is what the author guidelines say: https://joss.readthedocs.io/en/latest/review_criteria.html#tests

Authors are encouraged but not required to have testing such as via continuous integration. Some sort of objective testing is required.

kellieotto commented 4 years ago

@kthyng Right now, I cannot find code that is directly testing the package. As @Ji-Zhang pointed out there are some examples, but when I try to run them they suffer from the error I pointed out in #7

kthyng commented 4 years ago

@kellieotto Ok makes sense. If the examples are not adequate to objectively test the code, once they work, then it would make sense to pursue this issue.