search

JiHong88 / suneditor

Pure javascript based WYSIWYG html editor, with no dependencies.
http://suneditor.com
MIT License
1.74k stars 309 forks source link

How to enter new line when upload image finish #1294

Open nvthuong11 opened 1 year ago

nvthuong11 commented 1 year ago

Version: 2.45.1

I want to use Keyboard to enter new line. image

Thank you!

SystemChanger commented 1 year ago

@nvthuong11 Hi! You can try my PR for it: https://github.com/JiHong88/suneditor/pull/1267

nvthuong11 commented 1 year ago

@nvthuong11 Hi! You can try my PR for it: #1267

Thank you for reply, I tried and it doesn't work. You can check my demo. https://codepen.io/thuonnv/pen/RwEoboZ I've copied your file: https://github.com/JiHong88/suneditor/blob/8c5e82359f07c0a92d8f9c43ebfd1e369f5eac13/dist/suneditor.min.js To file: https://customappstore02062023.myshopify.com/cdn/shop/t/1/assets/suneditor.min.js?v=41654728684273330901693899051

Thank you,

SystemChanger commented 1 year ago

@nvthuong11 Hi! You can try my PR for it: #1267

Thank you for reply, I tried and it doesn't work. You can check my demo. https://codepen.io/thuonnv/pen/RwEoboZ I've copied your file: https://github.com/JiHong88/suneditor/blob/8c5e82359f07c0a92d8f9c43ebfd1e369f5eac13/dist/suneditor.min.js To file: https://customappstore02062023.myshopify.com/cdn/shop/t/1/assets/suneditor.min.js?v=41654728684273330901693899051

Thank you,

Yes, your codepen demo doesn't work ;) I've removed your external script link in the codepen and added the text from PR's min.js file (https://github.com/JiHong88/suneditor/blob/8c5e82359f07c0a92d8f9c43ebfd1e369f5eac13/dist/suneditor.min.js) directly to the <script> tag, and it worked like a charm.

image

Maybe there is something wrong with the file you tried? Some caching or else.

Your file in codepen is not the same as the file from the PR. image

nvthuong11 commented 1 year ago

Hi @SystemChanger,

Thank you so much!, I've added the URL of the JS file to Codepen HTML. It's working now.

Also, I have another question. When will this feature be released and updated for Suneditor React (https://github.com/mkhstar/suneditor-react)

Thank you!

SystemChanger commented 1 year ago

@nvthuong11 I'm glad that I was helpful! Unfortunately, I can't answer your question, because I am not a package maintainer. I just saw the lone soul with the same problem as I had earlier (before I did that PR) ;)

nvthuong11 commented 1 year ago

@SystemChanger,

Yes, thank you again.