search

JiYuanFeng / MCTrans

Apache License 2.0
111 stars 34 forks source link

The implement of NonLocalUNet is quiet different from the official implement #15

Closed Lloyd-Pottiger closed 2 years ago

Lloyd-Pottiger commented 2 years ago

The implement of NonLocalUNet in this repo is VGG encoder + NonLocal center + UNet decoder, but the official implement is: replacing upsample and downsample with Global Aggregation Block, reduce the layers of UNet and replace the Concatenation with Add. Refer to https://github.com/divelab/Non-local-U-Nets、https://arxiv.org/abs/1812.04103

JiYuanFeng commented 2 years ago

Hi, thank you for pointing this out. In fact, in the paper, we did not compare with NonLocalUNet, instead of comparing with the method of UNet + NonLocal operation.

Lloyd-Pottiger commented 2 years ago

You are right. Maybe you should change NonLocalUNet into UNet+NonLocal in README which may be missleading.

JiYuanFeng commented 2 years ago

Yes, thank you for the suggestion!