JiaShun-Xiao / face-alignment-ert-2D

implement of "One millisecond face alignment with an ensemble of regression tree" in python
37 stars 13 forks source link

Fix bug in tree build function #3

Closed Fnd3r closed 2 years ago

Fnd3r commented 2 years ago

First commit: When buid tree function call find_best_split, there is no sum of targets and number of targets in root node. Therefore, left_sum will be -right_sum and lcnt = -rcnt.

Second commit: Only swapped variable "w" and "h" because w belongs to variable x and h belongs to variable y. Anyway, there is more places in the code where variable x indicates y-coordinate because in Menpo library, the first coordinate is y-coordinate not x.