search

JiahaoPlus / SAGA

[ECCV 2022] SAGA: Stochastic Whole-Body Grasping with Contact
https://jiahaoplus.github.io/SAGA/saga.html
MIT License
68 stars 3 forks source link

A possible bug in fittingop #1

Open lzhyu opened 1 year ago

lzhyu commented 1 year ago

https://github.com/JiahaoPlus/SAGA/blob/ecaed33b580afbfa61a29a8b6bd4ad019de91108/WholeGraspPose/models/fittingop.py#L183-L184 In line 183, it seems that the third positional argument should be the normals of markers.

DonlynLee commented 11 months ago

Hi, have you encountered the problem that "TypeError: init() takes 1 positional argument but 3 were given", when running opt_grasppose.py ?

lzhyu commented 11 months ago

Hi, have you encountered the problem that "TypeError: init() takes 1 positional argument but 3 were given", when running opt_grasppose.py ?

Sorry. I have not.

DonlynLee commented 11 months ago

Thanks for your reply. Could you tell me your pytorch version? By the way, you proposed a possible bug in fittingop, so should we change the third positional argument to normals of markers? Thank you so much.