search

JianGoForIt / YellowFin

auto-tuning momentum SGD optimizer
Apache License 2.0
422 stars 93 forks source link

Potentially dead tf.assert Op #12

Closed ilya-eder closed 7 years ago

ilya-eder commented 7 years ago

It seems that there is an assert operation which might never be evaluated: tf.assert_equal(tf.size(root), tf.constant(1) ) https://github.com/JianGoForIt/YellowFin/blob/master/tuner_utils/yellowfin.py#L180

Newer versions of TF produce an error with that, and it was probably not the intended behaviour.

Related issue: https://github.com/tensorflow/tensorflow/issues/11315

JianGoForIt commented 7 years ago

@ilya-edrenkin Thanks for the detailed information. We have fixed this in master branch.