search

JianGoForIt / YellowFin

auto-tuning momentum SGD optimizer
Apache License 2.0
422 stars 93 forks source link

`lr` vs `learning_rate` #3

Closed rasbt closed 7 years ago

rasbt commented 7 years ago

Just gave yellowfin a try yesterday and it works nicely! Just a minor comment/suggestion:

what do you think about renaming lr to learning_rate for consistency with other tensorflow optimizers. Can open a small PR

JianGoForIt commented 7 years ago

Thanks @rasbt for pointing out. We will consider this in later cleaning-up stage.

JianGoForIt commented 7 years ago

Hi @rasbt, we have updated the argument name. Please check it out.

rasbt commented 7 years ago

Oh cool, that was quick! Thanks!