search

JianLoong / malaysia-api

A REST API about states in Malaysia. 🇲🇾
https://jian.sh/malaysia-api/
MIT License
28 stars 20 forks source link

Updating and adding of various flag and crest URL. #44

Closed JianLoong closed 2 years ago

JianLoong commented 2 years ago

Currently, the flag and crest URLs of the various states point to the Wikipedia website entry. (Where the user can choose the download the SVG or PNG file).

This can be improved by adding the path to the image itself instead.

For example in the file state/v1/johor.json the

"flag_url" information is currenty

"https://en.wikipedia.org/wiki/Johor#/media/File:Flag_of_Johor.svg"

when it should be instead

"https://upload.wikimedia.org/wikipedia/commons/5/5a/Flag_of_Johor.svg"

This is the same as several other entries.

Besides that, several states are also missing this information including, Kedah, Kelantan and a few others.

AraanBranco commented 2 years ago

I can working on this?

JianLoong commented 2 years ago

Sure. Assigned it to you. 👍