JianmengYu / ElonaPlusCustom-GX

Elona+ variant based on Custom-G
88 stars 6 forks source link

TL/Item name changes #4

Closed lIllIIlI closed 9 months ago

lIllIIlI commented 9 months ago

text.hsp

db_item.hsp

Stuff I didnt change: shining long hand -> can be Shining Long Needle, (巨大な長針), 針 can translate to both needle and hand, like a clock hand, so I left it.

Still need to change Quality, Ranks, type and food names image

JianmengYu commented 9 months ago

I really don't know how to say about this, but I think capitalizing the entire ioriginalnameref is very, very questionable to me. Personally, I absolutely do not want my itemnames capitalized (maybe except the unique items). So I was thinking maybe making a function _ioriginalnameref() that calls capitalize or uppercase the words after reading from ioriginalnameref, with it's behavior changable with either a tweak or a setting, if people want to, and the Item Highlight function AnnaBanana made could make use of that.

I do agree with the changes to iknownnameref(unidentified item name) though, because Ano often left these either empty or unchanged(after copying from elsewhere). Like High Potion of Physical (which I found weird as hell), the original unknown text is just clear liquid, but the jp text is Novelty Medicine so I changed the en text to that.

About the other translation changes, I know this sounds exceedingly dumb from some Chinese guy with sucky English, sucky Japanese, and sucky Chinese even. Wiki consistency aside, I don't feel like some of the translation to be unnecessary.

Plural cases like panty is handled in BLOODYSHADE CUSTOM's Proper plural for items, change that if you want to.

I'm sorry if this makes you feel like having your effort put to waste, I will diff your item_db to list the non-capitalize changes you made, and see if fixes like Heavy Crushing Ball, Intertwined Ring can be applied.

JianmengYu commented 9 months ago

Maybe I'm getting too old and used to Ano's bad translations..

lIllIIlI commented 9 months ago

Thanks for looking it over, I agree with your points. Since I noticed you were filling out the item descriptions recently I knew some of these changes would be redundant or resolved by the time you finished, so no problem with that. About the Nyoi case, i dont know. My GPT crossed with DeepL said it meant 'at one's will', but also 'satisfaction' and 'desire', and since I saw on wiki it was just a fluffy earpick, I couldn't see the context referring to Nyoi-bo. Ano lore...

JianmengYu commented 9 months ago

Capitalization config option (under Message/Log settings) added in bb818d43fbb9de35d49cd5eb9b8655cfc2a769a0. Applied some translations.