Jianxff / droid_metric

run DROID-SLAM with Metric3D to improve monocular performance
BSD 3-Clause "New" or "Revised" License
49 stars 3 forks source link

Doubt on parameters #6

Closed gmberton closed 1 month ago

gmberton commented 1 month ago

Hi, thank you for the cool repo, I found it really nice and easy to use :)

I see that the depth.py take as input --images while run.py and mesh.py take --rgb. Is it supposed to be the same parameter / same path?

Also, the code doesn't work with the latest version of matplotlib (3.9), perhaps it would be better to set matplotlib<=3.8 in the requirements.txt. With matplotlib 3.9 I get this error AttributeError: module 'matplotlib.cm' has no attribute 'get_cmap'

Jianxff commented 1 month ago

THANKS for your feedback! Parameter image and rgb means the same path to the folder of RGB images, I will make it more clear soon. The function get_cmap is for visualization of depth map, which is unnecessary, you can annotate it.

gmberton commented 1 month ago

Thank you for your quick reply!