Jiaoma / chipmunk-physics

Automatically exported from code.google.com/p/chipmunk-physics
MIT License
0 stars 0 forks source link

[PATCH] chipmunk 5.3 generates warnings when implicit 64-to-32 bit conversion is enabled #20

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
If you compile Chipmunk 5.3 in Xcode with "generate warningon implicit 
conversion from 64-to-32", it will generate 3 warnings.

This patch removes the warnings.

Original issue reported on code.google.com by ricardoq...@gmail.com on 10 Aug 2010 at 2:14

GoogleCodeExporter commented 8 years ago
Please, ignore the previous patch. I'll upload a new one a in few minutes.

Original comment by ricardoq...@gmail.com on 10 Aug 2010 at 2:18

GoogleCodeExporter commented 8 years ago
Sorry, the patch works OK.

I found another bug, but it is not 100% reproducible.
I thought it was related to my patch, but it is not.

I'll open a new bug.

Original comment by ricardoq...@gmail.com on 10 Aug 2010 at 5:20

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Fixed. Though I used single precision floats instead of ints. That seems to me 
more cross-compiler friendly.

I remembered to add the flag to the iPhone static lib build this time as well 
so hopefully you won't have to remind me again. ;)

Original comment by slemb...@gmail.com on 10 Aug 2010 at 5:44

GoogleCodeExporter commented 8 years ago
Hrm. Actually, this was the same spots as the last time you reported the issue. 
I could swear remember fixing and committing it then... I wonder how I messed 
that up?

Original comment by slemb...@gmail.com on 10 Aug 2010 at 5:46