search

JiapengWu / TeMP

Temporal Message Passing Network for Temporal Knowledge Graph Completion
55 stars 18 forks source link

A question about SARGCN #13

Closed striderdu closed 2 years ago

striderdu commented 2 years ago

Hi, Jiapeng, thanks for released code. I want to know some detail about SARGCN. https://github.com/JiapengWu/TeMP/blob/53e90c1e337615cfaa91c2cbfb21e2ed53842104/models/SelfAttentionRGCN.py#L97-L102 As above, update_time_diff_hist_embeddings does not return anything so that attn_mask and hist_embeddings will not be updated. This may impact the output of self attention module. I hope you can answer my doubts. Thanks a lot!

ljn0320 commented 2 years ago

Hi, Jiapeng, thanks for released code. I want to know some detail about SARGCN.

https://github.com/JiapengWu/TeMP/blob/53e90c1e337615cfaa91c2cbfb21e2ed53842104/models/SelfAttentionRGCN.py#L97-L102

As above, update_time_diff_hist_embeddings does not return anything so that attn_mask and hist_embeddings will not be updated. This may impact the output of self attention module. I hope you can answer my doubts. Thanks a lot!

Hello, there are some problems when I configure the environment. Is your environment configured according to readme? My dgl can't find the version 0.4.1, and then there are many errors. What version is your dgl？thanks！！

striderdu commented 2 years ago

Hi, Jiapeng, thanks for released code. I want to know some detail about SARGCN. https://github.com/JiapengWu/TeMP/blob/53e90c1e337615cfaa91c2cbfb21e2ed53842104/models/SelfAttentionRGCN.py#L97-L102

As above, update_time_diff_hist_embeddings does not return anything so that attn_mask and hist_embeddings will not be updated. This may impact the output of self attention module. I hope you can answer my doubts. Thanks a lot!

Hello, there are some problems when I configure the environment. Is your environment configured according to readme? My dgl can't find the version 0.4.1, and then there are many errors. What version is your dgl？thanks！！

Hi, @ljn0320 . My dgl version is 0.6.1. To do this, I modified some code that create DGLGraph objects. Hope my reply can help you.

JiapengWu commented 2 years ago

Sorry, I have graduated and no longer have the energy to maintain/update this project.

JiapengWu commented 2 years ago

There needs to be some adjustment to the implementation to adapt to a higher version of DGL.

striderdu commented 2 years ago

Sorry, I have graduated and no longer have the energy to maintain/update this project.

Okay, I got it. Thanks for your reply~

ljn0320 commented 2 years ago

Hi, Jiapeng, thanks for released code. I want to know some detail about SARGCN. https://github.com/JiapengWu/TeMP/blob/53e90c1e337615cfaa91c2cbfb21e2ed53842104/models/SelfAttentionRGCN.py#L97-L102

As above, update_time_diff_hist_embeddings does not return anything so that attn_mask and hist_embeddings will not be updated. This may impact the output of self attention module. I hope you can answer my doubts. Thanks a lot!

Hello, there are some problems when I configure the environment. Is your environment configured according to readme? My dgl can't find the version 0.4.1, and then there are many errors. What version is your dgl？thanks！！

Hi, @ljn0320 . My dgl version is 0.6.1. To do this, I modified some code that create DGLGraph objects. Hope my reply can help you.

Thank you very much for your reply, which has solved my doubts. I am now working on my graduation project. Can you share your code? Thanks again!