search

JiayangYing / CITS3403_PRO

MIT License
2 stars 0 forks source link

BUG: Image upload at insert product page #47

Closed sleepadept closed 4 months ago

sleepadept commented 4 months ago

Unable to upload images on insert product page

loklokyx commented 4 months ago

Oh, it slipped my mind that I created the template without making it functional. Could you please assist with this? I'm currently working on other features. Your kind help is greatly appreciated. Thank you!

sleepadept commented 4 months ago

No worries, I will try to fix it. Will consult with you if I need any clarifications. @loklokyx

sleepadept commented 4 months ago

I think also in the insert product page, we need to make predefined options, especially for Category and Condition. This would reduce unnecessarily repetitive inputs by users. What do you think? @loklokyx

loklokyx commented 4 months ago

You're absolutely right, that's a great suggestion. You're very observant and attentive to details!

sleepadept commented 4 months ago

I have just added some commits to fix the bugs and improve the functionality (using dropdowns) and clarity on the price (add "$" sign). Please kindly review it @loklokyx

loklokyx commented 4 months ago

I noticed that the maximum number of uploaded images is currently set to 3. I suggest increasing it to 4, as I've found I can upload more than that. Additionally, the checkbox should be limited to only one selection, but I've been able to check more than one. It seems like there might be an issue with the JavaScript. Could you please review it? Thank you!

sleepadept commented 4 months ago

Will have a look today @loklokyx. Accidentally had a good sleep last night 😪

sleepadept commented 4 months ago

Hi @loklokyx, I have updated the js and HTML, please kindly review it. I max'ed the image upload to 6, as I think it might be useful for some product categories that might need to show more images to buyers. Let me know what you think. Thanks!

loklokyx commented 4 months ago

Looks good, I think can create PR for it. Thanks.

sleepadept commented 4 months ago

Closed #53