search

Jieiku / abridge

Fast & Lightweight Zola Theme
https://abridge.pages.dev/
MIT License
142 stars 41 forks source link

Translation request of "Results For:" in i18n toml files #153

Closed DaniSancas closed 8 months ago

DaniSancas commented 8 months ago

Hi @Jieiku, first of all thank you very much for your hard work and effort on Abridge Zola Theme.

I have my blog for almost a year now and that's my theme since the beginning :raised_hands:

Continuing with my petition:

I have my blog entirely in spanish (not using multilanguage feature) and today I'm thinking about enabling the search. I see that automatically the search bar text is "Buscar" instead of "Search" which is amazing! However, if I search something I see that the result string is "Results For: your_search_term". I think it would be perfect if that string could be included in i18n/es.toml file (and for other languages as well).

image

Thank you again for everything! Let me know if you need something else to help you with this request.

Jieiku commented 8 months ago

The translations normally come via Zola, but zola cannot build js files. (https://github.com/getzola/zola/issues/2167#issuecomment-1520746832)

I think instead simply using a search icon would be sufficient: (alternatively I could show only the search term, and skip the search icon altogether)

2023-10-22_11-16-36

Jieiku commented 8 months ago

Fixed: https://github.com/Jieiku/abridge/commit/8bca9db5ecb24813e83f5e5bdd2bf87c16ba06e4