Jieiku / abridge

Fast & Lightweight Zola Theme
https://abridge.pages.dev/
MIT License
168 stars 45 forks source link

Double Search Icons, top menu centering #68

Closed Jieiku closed 2 years ago

Jieiku commented 2 years ago

Originally posted by @simbleau in https://github.com/Jieiku/abridge/issues/10#issuecomment-1151476914

Looks awesome!

Only 2 minor things

image

Originally posted by @simbleau in https://github.com/Jieiku/abridge/issues/10#issuecomment-1151476914

Jieiku commented 2 years ago

@simbleau

I previously looked at centering the top menu when it overflows to two rows, and did not find an elegant solution at the time, you would think it would be simple enough but nothing I tried worked.

The Home button is redundant since the Logo also takes you home, so I could remove that, but it dont actually resolve the problem in the case of people adding more links to the menu.

How did you get that image that shows the double search icons?

Notice the two icons are not the same icon, I think android might be taking it upon itself to add that extra icon.

Was that from a desktop browser in a special mode? Was it from an android emulator? Was it from an actual phone, and if so what version of android, and what display resolution (or the device model and I can lookup the resolution)?

Here is how it looks on my physical phone (LG G7 ThinQ, Android 9):

Capture+_2022-06-09-11-59-34

simbleau commented 2 years ago

It is from Safari on my iPhone 13... hmm

Jieiku commented 2 years ago

I might have an idea for this, but I will need you to test it, I dont own an iphone. I am not sure if I will get to it today or not, got some errands to run.

Jieiku commented 2 years ago

I changed the form input box for the search from type="search" to type="text" and I believe this should fix it.

Let me know how it looks on your phone now.

simbleau commented 2 years ago

Bingo

image