search

Jigsaw-Code / outline-apps

Outline Client and Manager, developed by Jigsaw. Outline Manager makes it easy to create your own VPN server. Outline Client lets you share access to your VPN with anyone in your network, giving them access to the free and open internet.
https://getoutline.org/
Apache License 2.0
8.19k stars 1.34k forks source link

fix(src/build): output child process stderr to console.error #1998

Open jyyi1 opened 1 month ago

jyyi1 commented 1 month ago

This PR redirects stderr of a child process to console.error. This allows us to view the build steps of client/src/tun2socks/build, because go run task will output to stderr.

Additionally, unnecessary line breaks have been removed to improve the readability of the output.

Before

image

After

image
daniellacosse commented 1 month ago

It just feels wrong to me, but okay! Disregard

On Fri, May 3, 2024, 12:01 PM Vinicius Fortuna @.***> wrote:

@.**** commented on this pull request.

In src/build/spawn_stream.mjs https://github.com/Jigsaw-Code/outline-apps/pull/1998#discussion_r1589399347 :

  • childProcess.stderr.on('data', error => forEachMessageLine(error, line => stderr.push(line)));
  • const stdErrPipe = newChildProcessOutputPipeTransform(line => {

BTW, as @jyyi1 https://github.com/jyyi1 pointed out, stderr output doesn't have to mean error. Logging uses that in general.

— Reply to this email directly, view it on GitHub https://github.com/Jigsaw-Code/outline-apps/pull/1998#discussion_r1589399347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4V5VADQ57SOUBGEETOZO3ZAOYFJAVCNFSM6AAAAABGWENO5SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZYGQ4DCMZUGY . You are receiving this because your review was requested.Message ID: @.***>