Jigsaw-Code / outline-apps

Outline Client and Manager, developed by Jigsaw. Outline Manager makes it easy to create your own VPN server. Outline Client lets you share access to your VPN with anyone in your network, giving them access to the free and open internet.
https://getoutline.org/
Apache License 2.0
8.22k stars 1.35k forks source link

Custom Errors in Google Sheets Dynamic Access Keys #2025

Open noahball opened 1 month ago

noahball commented 1 month ago

Is there an existing issue that is already proposing this?

Application

Outline Client

What are you trying to do? What is your use case?

v1.13.0 of the Outline Client introduced Custom Errors for Dynamic Access Keys.

It appears that this only applies to keys that are stored in a JSON file. I tried storing the error JSON inside of the first cell of the sheet no avail - and the wiki only mentions this for JSON keys. It would be great if this feature could be added to support dynamic keys that are stored in a Google Sheet.

Is your feature request related to a problem? Please describe it.

No response

Describe the solution you'd like.

The ability for error messages to be stored in Dynamic Access Keys that are hosted on Google Sheets. This could be as simple as having the same error JSON object in the first cell, or something similar to how it works for JSON keys.

Describe alternatives you've considered

No response

sbruens commented 1 month ago

Unfortunately, Google Sheets cannot serve JSON. It can serve CSVs, but we don't support CSV.

We could potentially attempt to unquote the first cell of the CSV. Marking as a feature request.