search

Jigsaw-Code / outline-apps

Outline Client and Manager, developed by Jigsaw. Outline Manager makes it easy to create your own VPN server. Outline Client lets you share access to your VPN with anyone in your network, giving them access to the free and open internet.
https://getoutline.org/
Apache License 2.0
8.46k stars 1.37k forks source link

install_linux_service.sh failed to install outline_proxy_controller.service when /usr/local/sbin not exist #843

Open stepan111 opened 4 years ago

stepan111 commented 4 years ago

Describe the bug I am trying to run Outline-Client.AppImage on Clear Linux. I found that when install_linux_service.sh tries to install outline_proxy_controller.service and copy OutlineProxyController binary to /usr/local/sbin/OutlineProxyController . But when /usr/local/sbin directory not exist it creates binary file with same name:

root@sb/tmp/6CHY9z # file /usr/local/sbin
/usr/local/sbin: ELF 64-bit LSB pie executable, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=d5650adfc0c1235b64d34f2ff750455f069bbf73, with debug_info, not stripped

That is the issue because in outline_proxy_controller.service we have hard-coded value:

ExecStart=/usr/local/sbin/OutlineProxyController --socket-filename=/var/run/outline_controller

Please update script the way it will verify if directory exist before copying binary.

To Reproduce Steps to reproduce the behavior:

  1. stop outline_proxy_controller.service
  2. remove /usr/local/sbin/ directory
  3. Try to connect to any Server with Outline-Client.AppImage

Expected behavior Outline-Client.AppImage will verify if directory exists and create it if needed

Desktop (please complete the following information):

stepan111 commented 4 years ago

Workaround to make Outline-Client.AppImage work is just create /usr/local/sbin/ directory manually.

THanks!

nuschpl commented 1 year ago

Will this ever be solved instead of workarounds ? This also causes some kind of obfuscation and unability to clean uninstall