search

Jigsaw-Code / outline-go-tun2socks

Apache License 2.0
227 stars 94 forks source link

Implement RFC7830 padding for queries #39

Closed dmcardle closed 4 years ago

dmcardle commented 4 years ago

Argh, so one other thing to think about is that the incoming message is not guaranteed to be fully label-compressed.

(As an aside, is it okay to compress messages that were not already compressed?)

I really should unpack and pack the rawMsg before using its length.

dmcardle commented 4 years ago

@bemasc Don't forget me :)

dmcardle commented 4 years ago

Friendly ping :)

dmcardle commented 4 years ago

Done, PTAL :)

dmcardle commented 4 years ago

There's a conflict to resolve because NewTransport() appears to have a new parameter. I'd resolve it, but it looks like TestNewTransport is currently failing on master.

bemasc commented 4 years ago

Thanks for the bug report. The test failure should be fixed by #42.

dmcardle commented 4 years ago

Just rebased on master to incorporate #42.

dmcardle commented 4 years ago

(Tests are passing now!)