search

Jigsaw-Code / outline-server

Outline Server, developed by Jigsaw. The Outline Server is a proxy server that runs a Shadowsocks instance and provides a REST API for access key management.
https://getoutline.org/
Apache License 2.0
5.79k stars 780 forks source link

fix(manager): adjust app container on narrow devices to make room for sidebar #1495

Closed daniellacosse closed 8 months ago

daniellacosse commented 8 months ago

this is horrible, I feel like god told me to kill my own brother

the sidebar and the main page for whatever reason are on different layers. I would have to restructure the UI and (possibly) rip out some of the components we're using to do it properly (they should be in a flex layout on the same layer). for now, to unblock the release I am simply using a grotesque media query to make room for the sidebar when the app is narrow.

my guess is this behavior started when our dependencies were updated at some point

fortuna commented 8 months ago

I don't understand what the issue is. We use the off-the-shelf https://www.webcomponents.org/element/@polymer/app-layout/elements/app-drawer-layout. It has always worked. What changed?

Edit: Oh, I see your comment on dependencies. Not clear to me how that would affect it, Polymer is not updated.