search

Jigsaw-Code / outline-server

Outline Server, developed by Jigsaw. The Outline Server is a proxy server that runs a Shadowsocks instance and provides a REST API for access key management.
https://getoutline.org/
Apache License 2.0
5.79k stars 780 forks source link

fix(manager/electron): adds hardened runtime and notarization options to the MacOS build #1508

Closed daniellacosse closed 7 months ago

daniellacosse commented 7 months ago

context provided here: https://github.com/Jigsaw-Code/outline-server/pull/1508#issuecomment-1942000793

daniellacosse commented 7 months ago

Could you add some more details to the PR to explain the "why" of this change? What changed since our last successfully notarized build that these changes were necessary? Would be helpful to have that record for future reference.

Uhhh Gemini Advanced, can you help me out??

JK - I don't fully know? It's one of two things:

  1. The api of electron/electron-builder changed and now notary options are passed through via notarize - this is more likely.
  2. recent changes to apple platforms require we "harden" the runtime, which requires additional entitlements (see this doc I found: https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/) and I figured, might as well do this too