fix(server): isOverDataLimit logic to stop allowing 0 traffic byte

Jigsaw-Code / outline-server

Outline Server, developed by Jigsaw. The Outline Server is a proxy server that runs a Shadowsocks instance and provides a REST API for access key management.

https://getoutline.org/

Apache License 2.0

5.79k stars 780 forks source link

fix(server): isOverDataLimit logic to stop allowing 0 traffic byte #1556

Closed cornzzy closed 2 months ago

cornzzy commented 3 months ago

issue #1515

This if statement is just wrong and doesn't block access when traffic limit is set to 0 byte. This one character fixes it.

Now if we create a new access key, set the limit to 0 before the first usage, the client no longer will be able to connect as expected.

cornzzy commented 2 months ago

I can't be a contributor. would you do it

sbruens commented 2 months ago

I can't be a contributor. would you do it

No problem. I added the requested changes to the PR.

sbruens commented 2 months ago

Merged and we'll try and get this released soon. Thanks again for your contribution @cornzzy!