search

Jigsaw-Code / outline-ss-server

Outline Shadowsocks server
https://getoutline.org
Apache License 2.0
745 stars 189 forks source link

fix: do not set the host address #217

Closed sbruens closed 2 months ago

sbruens commented 2 months ago

This was a regression introduced in #192, which was rolled out in outline-server v1.10.0 released last week and caused issues for users using machines with IPv6 disabled: https://github.com/Jigsaw-Code/outline-server/issues/1601.

I'm unable to reproduce the issue itself when IPv6 is disabled on my corp or DigitalOcean machines, but that may be specific to those machines.

sbruens commented 2 months ago

LGTM. But we need to verify whether it will fix the issue.

Agreed, though I'm still unable to reproduce this issue, on a host machine or in a Docker container. I had wanted to replicate this in the outline-server integration test, but to no avail. I propose merging this change and, as you suggested offline, creating a new canary release that we could ask affected folks to test.

Probably we can also have some configuration that let the user explicitly specify the IP stack (v4 or v6).

The new service config allows this now at the outline-ss-server layer; the new configuration allows a full address specification, instead of just a port:

https://github.com/Jigsaw-Code/outline-ss-server/blob/cb5965fd1a6982b641c640067b55bcdb1ccca8eb/cmd/outline-ss-server/config_example.yml#L20

But we don't yet support this at the outline-server/Manager layer. I agree it would be nice to explicitly specify the stack there, but I'm also not sure it's totally necessary.