search

Jij-Inc / pyo3-stub-gen

Stub file (*.pyi) generator for PyO3
Apache License 2.0
61 stars 12 forks source link

Add `chrono` feature #78

Open ThatOneShortGuy opened 2 months ago

ThatOneShortGuy commented 2 months ago

Fix for #77. Implemented as a new feature chrono just like pyo3 does. I didn't know whether to make it a default feature, but it is now following the pattern from numpy.

termoshtt commented 2 months ago

Thanks PR!

I didn't know whether to make it a default feature, but it is now following the pattern from numpy.

No need to introduce a new feature for chrono support. This should be similar to num_complex case https://github.com/Jij-Inc/pyo3-stub-gen/blob/main/pyo3-stub-gen/src/stub_type/builtins.rs#L39C1-L40C50 Could you fix not to use feature?

ThatOneShortGuy commented 2 months ago

Here, the feature part has been removed.

xnerhu commented 1 month ago

when is it gonna be merged?

ThatOneShortGuy commented 1 month ago

@termoshtt

gsleap commented 1 month ago

Hi, thanks for adding this PR. I'm eagerly awaiting the PR to be approved, as my rust pyo3 project also needs chrono support!

ThatOneShortGuy commented 4 weeks ago

Hi, thanks for adding this PR. I'm eagerly awaiting the PR to be approved, as my rust pyo3 project also needs chrono support!

@gsleap in the meantime, I use the PR repo

[dependencies]
pyo3-stub-gen = { branch = "chrono_feature", default-features = false, optional = true, git = "https://github.com/ThatOneShortGuy/pyo3-stub-gen" }