Jikoo / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
120 stars 41 forks source link

Bug removed inventory #120

Closed Mundo-Minecraft closed 1 year ago

Mundo-Minecraft commented 1 year ago

Good morning, I have detected an error when using OpenInv with EssentialsX (https://ci.ender.zone/job/EssentialsX/) I have both updated to their latest version.

To reproduce the bug you have to use spectator mode. Write /gmsp and disconnect from the game, if another "moderator" accesses your inventory with /openinv "player" when this player re-enters your inventory will be empty.

Greetings and thanks for the support and for the plugin.

Jikoo commented 1 year ago

Essentials' gamemode command does not do anything beyond change gamemode, and OI/Minecraft in general doesn't handle spectators differently. If you're experiencing inventory inaccuracy or loss, please make sure you're not running some kind of per-gamemode/per-world/cross-server inventory system.

Mundo-Minecraft commented 1 year ago

Sorry, I haven't given you all the information. I forgot to mention that I also use perworldinventory (https://github.com/EbonJaeger/perworldinventory-kt)

This happens to me in version 1.19.3. Perworldinventory does not require updating but both essentials and openinv did update and that was when the errors started. I have loaded old versions of essentialsx and this error keeps happening.

The error is as commented, if you write /gmsp you disconnect and connect there is no error. But if when you are offline you access with openinv when the user logs back in he has no inventory.

Jikoo commented 1 year ago

You should be using your inventory management plugin's method for offline access - OI only supports vanilla inventory.