Jikoo / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
120 stars 41 forks source link

Update to Minecraft 1.20 #148

Closed Jikoo closed 1 year ago

Jikoo commented 1 year ago

Per usual, I am pushing the work out now rather than make technically-savvy early adopters wait until I have time to test. Builds are available in the "dist" artifact of successful Actions runs.

Jikoo commented 1 year ago

Most things work fine, the only issue is blocked double chests with silent+any active. Presumably this is because OI opens its own copy of the view inventory, so then the viewer counter gets decremented erroneously on exit? Not sure, need to debug. Single chests, unblocked chests, and shulkers do not suffer this issue. image

Jikoo commented 1 year ago

Ever have one of those moments where you dig through NMS for like 30 minutes only to realize it was a non-NMS change that wasn't thoroughly tested that messed things up? Me too. Really gotta write some unit tests, dang it.