search

Jikoo / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
119 stars 41 forks source link

Crashing on paper 1.21 #232

Closed fandasliz closed 3 months ago

fandasliz commented 3 months ago

Hello, after updating server to minecraft version 1.21 using paper 1.21 (123) our server started crashing. We use OpenInv version 5.0.0. Server stopped responding multiple times right after opening enderchest through /openender or /oe resulting in crash. We are using /oe multiple times without any problems but sometimes it causes the server to stop responding once or two times per day randomly after typing /oe. Attached is crash log from paper. Thanks for any help or advice. 2024-08-04-4.log

Jikoo commented 3 months ago

Looks like shift clicking to/from an /openender enderchest. Do you happen to have any idea what the contents were or which slot was clicked?

fandasliz commented 3 months ago

Sorry don't know if player clicked on any slots it seemed like it stopped responding immediately after typing /oe. I found ender chest contains. I tried to reproduce it but had no success. Thanks for answer. image image - custom decorated pot

Jikoo commented 3 months ago

Hm, okay, thank you either way, that gives me a setup to poke around with. The trace does indicate that they shift-clicked something, but both the top and bottom are vanilla menu slots in the ender chest menu, so it can't be narrowed down further without being able to reproduce or get in touch with the player.

The weird part is that the traces don't point deeper into the backing container, because the method being called should just be a direct call to the backing container's content.

fandasliz commented 3 months ago

After further testing I figured out that shift clicking stone into full /oe stopped server from responding every time I tried that. Seems like it doesn't matter at which slot stone was as long as ender chest was full and I shift clicked more stone from inventory. Thanks again for answer. Inv example: image Edit: Looks like shift clicking other items into full oe does the same thing.

Jikoo commented 3 months ago

Thank you for the assistance, particularly the screenshots. I was struggling to reproduce consistently despite knowing what the cause was after doing a little debugging. Turns out there was a second mistake causing the final slot to overwrite the result of the shift click, so only the item in the final slot of the inventory causes the freeze.