search

Jikoo / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
119 stars 41 forks source link

Onlining player during editing not functioning properly #246

Closed JHarris12345 closed 2 months ago

JHarris12345 commented 2 months ago

If you are editing an offline player's inventory and they come online mid-edit, you are no longer editing their inventory

Jikoo commented 2 months ago

Could I get your server and OpenInv /version please? I probably won't have time to dig into this until the weekend, but that way I can at least be ready.

JHarris12345 commented 2 months ago

Plugin ver is 5.1.1 and server ver is 1.21.1

Jikoo commented 2 months ago

~~1.21.1 is a Minecraft version, not a Bukkit server implementation version. In this case /version is really important, because this is a problem I had already encountered and solved during the 1.21 update. If this is a Paper server I need to check whether it occurs on Spigot or if it's a Paper-specific problem so I can look at the correct areas. The commit hashes (or build number for Paper) included in the output of /version are also useful for determining what changes may have been made by the server implementation since I last verified functionality, which allows me to track down where a problem might be occurring way faster.~~

Never mind, turns out I broke it between 5.0.0 and 5.1.1 by deleting the little bit where the updated player gets sent to the inventory during a refactor dividing up the listener. Hooray for easy fixes, though boy howdy is it embarrassing. Can't wait to write the changelog where I tactfully avoid telling everyone how dumb I was.

Jikoo commented 2 months ago

https://github.com/Jikoo/OpenInv/releases/tag/5.1.2