search

Jikoo / OpenInv

Open anyone's inventory as a chest, real-time!
GNU General Public License v3.0
118 stars 38 forks source link

Why it uses owner's locale instead of command sender's locale? #95

Closed molor closed 1 year ago

molor commented 2 years ago

https://github.com/Jikoo/OpenInv/blob/8c7698b40ed7d5af1df418e4ccc0bb1e48f57e3f/plugin/src/main/java/com/lishid/openinv/internal/OpenInventoryView.java#L70

As I have now found out, some of my players are playing with the game in Chinese language :o Okay, it's their choice, but why I should see their inventory in their locale instead of my game language? I'm opening their inventory for myself, not for them.

Hope this can be changed because yml translating file, Sure I can create the yml file manually but every 1-2 months I find at least one player with a new language for which there is no that file, and creating it for each of the 100+ built-in game languages for the one plugin sounds like I have nothing to do. So console will continue to flood with incomplete translation warnings..

Jikoo commented 2 years ago

Nice spot, whoops. You can submit a PR if you'd like, otherwise I'll get to it when I finish the latest round of fixes for Mockbukkit/Spigot breaking various builds of mine.