Added configuration option for aditional labels

Criptos commented 9 years ago

  dialogTimeRemaining: 'Time remaining',
  dialogStayLoggedIn: 'Stay Logged In',
  dialogLogOutNow: 'Log Out Now',

JillElaine commented 9 years ago

This is a good change to make the plugin work for any language. There is one other line that should also be configurable: the 'alert' in the 'construct' (ie: 'Please disable "Private Mode", or upgrade to a modern browser. Or perhaps a dependent file missing. Please see: https://github.com/marcuswestin/store.js'). Could you also add that? Thank you.

Criptos commented 9 years ago

I made the change, but I don't know if I need to make another pull request, or if both commits will merge with a single pull request :)

JillElaine commented 9 years ago

Okay, great! Further changes that need to be made:

In configuration section, change 'name' of dialogPrivateMode -> errorWarningMessage
In configuration section, separate errorWarningMessage line by one blank line from dialog configuration lines (it is not part of the dialog box configuration)
In jquery-idleTimeout.js, line 123, ...'display:inline'>"+opts.dialogTimeRemaining+"<div style='display:inline'... -> ...'display:inline'>" + opts.dialogTimeRemaining + ": <div style='display:inline'... (note addition of colon (:) and space)
Modify "var dialogContent = ..." line in both jquery-idleTimeout-for-testing.js and jquery-idleTimeout-iframes.js to include your new dialogTimeRemaining var (Sorry for the tedious 3 files to modify with all changes)
Make all code JSLint compliant http://www.jslint.com/ (More tediousness, but makes for consistent code)
After above changes, recreate jquery-idleTimeout.min.js and jquery-idleTimeout-iframes.min.js

In Git, squash can be used to combine several commits into one.

Your assistance is appreciated. Thank you.

JillElaine commented 9 years ago

Added all configuration changes as suggested. Closes pull request.

JillElaine commented 9 years ago

Criptos, thank you for the work you did to make this plugin ready for any language. Your changes have been incorporated into the plugin now.

Jill Elaine On 12/30/2014 08:11 AM, ANDRES TELLO wrote:

I made the change, but I don't know if I need to make another pull request, or if both commits will merge with a single pull request :)

— Reply to this email directly or view it on GitHub https://github.com/JillElaine/jquery-idleTimeout/pull/12#issuecomment-68369402.

JillElaine / jquery-idleTimeout

Added configuration option for aditional labels #12