search

JillElaine / jquery-idleTimeout

Idle activity timeout and logout redirect for jQuery for multiple windows & tabs
Other
72 stars 79 forks source link

Added option to enable/disable dialog display. #8

Closed ghost closed 10 years ago

JillElaine commented 10 years ago

Thanks, icoast. I'll have a look at this soon.

JillElaine commented 10 years ago

@icoast This works well. If enableDialog = false, the browser title warning is also disabled. I assume this matches the intent of a 'silent log out' with no warning to the idle user?

ghost commented 10 years ago

Correct. In my case there should be no prompt or warning about idling.

ghost commented 10 years ago

That's weird, no idea why I would change that line. It was a mistake. It's been reverted to the original dependency URL.

JillElaine commented 10 years ago

Okay! All looks good. I will merge this soon, when I have time to update the documentation too. Thank you for the patch. Appreciated.

JillElaine commented 10 years ago

After some thought about this modification, I think that, if the warning dialog is disabled in the configuration, all the functions related to the warning dialog should not run in the script. For example, checking if the dialog is open: it won't ever be open, so we shouldn't check. Also the dialogDisplayLimit should be ignored: the logoutUser function should run as soon as the idleTimeLimit is met.

What do you think?

JillElaine commented 10 years ago

I've added your suggested functionality, with a few modifications as described above. Much appreciate the feedback!

ghost commented 10 years ago

You work too quick! I agree with your suggestion and now what you've implemented. Great plugin made better. Thanks.

JillElaine commented 10 years ago

You provided a good suggestion, and was happy to implement it. Just modified your code a bit. Thanks again.