search

Jillzyt / pe

0 stars 0 forks source link

Assigning macro with add command and illegal parameters causes macro cannot be used. #10

Open Jillzyt opened 3 years ago

Jillzyt commented 3 years ago

Assigning macro with add allows a different type of parameter to be added in which results in unable to use the macro.

Add macro does not allow pd/ parameter.

image.png

image.png

Success example command:

image.png

image.png

Recommendations: Maybe warn the users when not allowed parameters are used as there's currently no features that help to edit the macro again. The users have to readd a new macro :(

nus-se-bot commented 3 years ago

Team's Response

It has already been written in the user guide and explained in the developer guide, that a vaild assignmacro command does not guarantee that the saved command is valid, as we give flexibility to the user to save partial commands into a macro, so that the macro used with different sets of additional arguments. Refer to the 2nd example of assignmacro command in the user guide for a concrete example.

Nonetheless, an error message for the respective commands will be shown if the macro is used in such a way that the underlying command is incorrect.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: It is an important issue as invalid macros should not be allowed in the first place for the application despite UG mentioning so. It is a flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users.