Jim-Duke / concordia-sacrae

Lilypond source for the music Concordia Sacrae performs
2 stars 0 forks source link

Season5/down in the river to pray #12

Closed nocollier closed 3 years ago

nocollier commented 3 years ago

This work is ready for comment, I have checked each part and listened to several midi files.

To make the merge a little easier I did not yet change the makefile, I figured we can change that in your PR.

Feel free to be picky, I tried to mostly stick with you style but it is my first attemp.

Jim-Duke commented 3 years ago

Still listening and examining notes. So far all looks correct. But I'll post this comment before finishing that.

Comments on the arrangement

Jim-Duke commented 3 years ago

Also, during this review I again realized how much I depend on measure numbers to review the music efficiently and make corrections. And that includes noting the measure number in comments in the source file. To make the measure numbers in the PDF we produce match the measure numbers in the original, you need to add the following line after the lead-in:

\set Score.currentBarNumber = #1

It only needs to be added to one voice. I usually add all the breaks and other Score-wide things to the first voice in the file.

I now see that you made several commits. I'll hold off on making my changes until after I see what you committed.

nocollier commented 3 years ago

This arrangement is weird. With that many consistent sharps, I knew it must have not really been in C. This is a trend I have seen in orchestral work as well--it is written in some key, but you don't get to know up front what it is.

I don't really care for the arrangement either, but as you say I could probably get used to it. From my view, this is a simple song that sounds best simple, but the arrangement likes to add additional moods and moving lines in strange places. We will see how it goes.

I made the changes you suggested before I saw your last comment, feel free to do what is easiest. If you like what you have we can even reject this PR and you can just push what you have. I will use all your suggestions from the beginning on the next one.

Jim-Duke commented 3 years ago

If needed I can make commits to your branch. No reason to reject the PR. The vast majority of the file is correct. The hard part - the notes and rhythms - is correct; with a few exceptions that I noted. I'll look over your changes and I think we can commit this. If you could look over my PR we can push these forward. I'll work on Ezekiel, since I have the sheet music. You keep working on digital content. There are two more scores available to work on. I'll be getting the first shipment of sheet music this Friday - and I'll make scans so we can keep working things.

nocollier commented 3 years ago

Ok, I will try to get to review your score tonight or maybe tomorrow. Thanks!