JimB16 / PokePlat

Disassembly of Pokemon Platinum
104 stars 16 forks source link

The target ROM is a known bad dump #6

Closed SatoMew closed 5 years ago

SatoMew commented 5 years ago

Xenophobia's dump has an underdumped header (source). This repository in its current state is thus not a disassembly of the real American Platinum v1.0 ROM.

As a reminder, there is an American Platinum v1.1 ROM which fixed a bug related to the GTS not found in other releases, and the English European Platinum ROM which censored the Game Corner using the same edits as the Korean versions of DPPt.

JimB16 commented 5 years ago

Some time is gone since I last thougt about changing the rom version. I knew that there were others out there, but sticked with this one because it was easier to find or sth like that. The header should be easy to fix though. Maybe it only needs an update to the README for this since I extract most data out of the baserom.nds that is provided by the user and use that to rebuild a new rom.

Thanks for the reminder.

JimB16 commented 5 years ago

Changed baserom to the American Platinum v1.1 ROM. Support for v1.0 will come when someone removed all incbins from that one overlay.