JimCurryWang / python-shopee

pyshopee - Shopee Partner API Client for Python
https://pypi.org/project/pyshopee
MIT License
210 stars 82 forks source link

Hotfix - Wrong function "shop_category/get" #13

Open linhnguyengts opened 5 years ago

linhnguyengts commented 5 years ago

it should be shop_categorys/get

JimCurryWang commented 5 years ago

Hi @linhnguyengts,

I have merged commit 0bc4c4c into master.

Besides i will send an issue to product team to see if we can name a better API route like shop_categories/get as well.

Thanks for the notice.

Before :

    def get_shop_category(self, **kwargs):
        """
        Use this call to get list of in-shop categories
        :param kwargs:
            : pagination_offset 
            : pagination_entries_per_page
        """
        return self.client.execute("shop_category/get", "POST", kwargs)

After:

    def get_shop_categories(self, **kwargs):
        """
        Use this call to get list of in-shop categories

        :param kwargs:
            : pagination_offset 
            : pagination_entries_per_page
        """
        return self.client.execute("shop_categorys/get", "POST", kwargs)