search

JimLee1996 / TrojanX

Trojan Client for macOS, ported from ShadowsocksX-NG. Please use it in compliance with laws, regulations and rules.
GNU General Public License v3.0
599 stars 106 forks source link

Scan QRCode from screen and import from clipboard failed #1

Closed dr1llc4t closed 4 years ago

dr1llc4t commented 4 years ago

Describe the bug Scan QRCode from screen and import from clipboard failed, only manually import works.

To Reproduce Use scan QRCode from screen or import from clipboard

Expected behavior Everything works just like ShadowsocksNG

Screenshots

截屏2020-02-2720 52 39

**System and TrajanX version:

teel-writ-ros commented 4 years ago

https://github.com/JimLee1996/TrojanX/pull/2

JimLee1996 commented 4 years ago

please see https://github.com/JimLee1996/TrojanX/releases/tag/0.2

lixingmao commented 4 years ago

貌似新版url 识别没有做编解码，如果 ULR 中包含特殊字符或者中文（一般在 URL 中#号后面部分），就会造成识别失败； 望后续有时间能修正。

teel-writ-ros commented 4 years ago

https://github.com/JimLee1996/TrojanX/commit/3cd0b24addf142c2aff4575dc62de81b200ed789#r37646079 这里的remark没有传参传进去 @timelessg

timelessg commented 4 years ago

remark is not valid parameter of trojan url,and you can see more at trojan's repository @caesarjing

teel-writ-ros commented 4 years ago

ok. so the client has to define the standard for remark if we were to implement this feature. thanks for clarification @timelessg