JimLiu / Lucene.Net.Analysis.PanGu

盘古分词(http://pangusegment.codeplex.com/ ),由于老版本不支持最新Lucene.Net 3.0.3,对其进行了升级,可以支持最新的Lucene.Net 3.0.3。可以直接NuGet安装。
Apache License 2.0
172 stars 106 forks source link

About .NET Core support #5

Open LonghronShen opened 7 years ago

LonghronShen commented 7 years ago

I have made an almost done migration for Lucene.Net.Analysis.PanGu on both .NET Standard 1.6 and .NET Framework 4.5.1 platforms. See my Lucene.Net.Analysis.PanGu netcore branch

See if we can merge the new branch back to yours. @JimLiu

JimLiu commented 7 years ago

Great job!

Send a Pull request please, I'll merge that.

LonghronShen commented 7 years ago

Still have some problems, the unit tests not all cleared. Lucene.Net 4.8 has changed a lot comparing to 3.03, so we need more tests. I'll send a PR to you, but you don't need to merge it now. After all tests passed, let's merge.

LonghronShen commented 7 years ago

Wait, my netcore branch is whole new from your master branch, so PR failed. Let's make a new netcore branch in your repository? @JimLiu

JimLiu commented 7 years ago

@LonghronShen I've added you as a Collaborator, so you can do what you want.

LonghronShen commented 7 years ago

OK, I'll create a new netcore branch, and make a PR. Currently what we need is writing more unit tests and see if the new Lucene.Net 4.8 is stable enough. And about the missing functionality in PanGu lib on .NET Standard 1.6 platform, mainly inlcuding:

LonghronShen commented 6 years ago

A .NET Core 2.0 port has been done and used internally for months, so I pushed my new netcore2.0 branch. Another, let's see if we can contribute the repository to the .NET China Community to involve more people in? @JimLiu