JimSellmeijer / raskal

raskal.games website
Apache License 2.0
0 stars 0 forks source link

Sweep: organize it better so that it's easier to maintain. Bring it to the standard of the framework it is in. #2

Open JimSellmeijer opened 9 months ago

JimSellmeijer commented 9 months ago
Checklist - [X] Modify `_includes/ekstase.html` ✓ https://github.com/JimSellmeijer/raskal/commit/ef3bc1f9eef3a26a0eb1a8319b73a1abb45674c6 - [X] Modify `_includes/press_kit.html` ✓ https://github.com/JimSellmeijer/raskal/commit/820d8acf8a3115aa186dbaf05f7555ff67ada3bb ![Flowchart](http://24.199.78.105:8082/public/f06e43ffd9d34c336c829948aaf47d04abb39fa4ba47138b1e78e6f12940dbc1_2_flowchart.svg)
sweep-ai[bot] commented 9 months ago

Here's the PR! https://github.com/JimSellmeijer/raskal/pull/4.

Sweep Basic Tier: I'm using GPT-4. You have 2 GPT-4 tickets left for the month and 0 for the day.

For more GPT-4 tickets, visit our payment portal. For a one week free trial, try Sweep Pro (unlimited GPT-4 tickets).

Actions (click)

Sandbox Execution X

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for 40df279
trunk init 1/3 ✓
⡿ Downloading Trunk 1.17.2...
⡿ Downloading Trunk 1.17.2...
⢿ Downloading Trunk 1.17.2...
⣻ Downloading Trunk 1.17.2...
⣽ Downloading Trunk 1.17.2...
⣾ Downloading Trunk 1.17.2...
⣷ Downloading Trunk 1.17.2...
✔ Downloading Trunk 1.17.2... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done

✔ 9 linters were enabled (.trunk/trunk.yaml)
  checkov 3.0.32 (2 yaml files)
  git-diff-check (81 files)
  markdownlint 0.37.0 (1 markdown file) (created .markdownlint.yaml)
  oxipng 9.0.0 (13 png files)
  prettier 3.0.3 (6 css, 19 html, 5 javascript, 1 markdown, 13 sass, 2 yaml files)
  svgo 3.0.3 (1 svg file) (created svgo.config.js)
  trivy 0.47.0 (2 yaml files)
  trufflehog 3.62.1 (81 files)
  yamllint 1.33.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt _includes/press_kit.html || exit 0 2/3 ✓
  FAILURES  
 prettier  _includes/press_kit.html  .trunk/out/W8XEM.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 0 files
✖ No issues, 1 failure
trunk check --fix --print-failures _includes/press_kit.html 3/3 ❌ (`1`)
  FAILURES  
 prettier  _includes/press_kit.html  .trunk/out/r0QOr.yaml
  NOTICES  
 A tool failed to run. You can open the details yaml file for more information.
Checked 1 file
✖ No issues, 1 failure
# .trunk/out/r0QOr.yaml
trunk_cli_version: 1.17.2
title: prettier exited with exit_code=2
report:
  - prettier exited with exit_code=2
  - linter:
      command: |
        /root/.cache/trunk/tools/prettier/3.0.3-f40a31f1cf22ae011727ab1e40e55171/node_modules/.bin/prettier -w _includes/press_kit.html
      stdin_path: (none)
      run_from: /tmp/trunk-0/e6rAJq/a57aSN
      timeout: 10m
      rerun: (cd /tmp/trunk-0/e6rAJq/a57aSN; env -i PATH=/root/.cache/trunk/tools/prettier/3.0.3-f40a31f1cf22ae011727ab1e40e55171/node_modules/.bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3/bin:/root/.cache/trunk/tools/node/18.12.1-00ae74f39ac4de3ff3c7e3686016ebf3:/root/.nvm/versions/node/v18.17.0/bin/:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin HOME=/root NODE_PATH=/root/.cache/trunk/tools/prettier/3.0.3-f40a31f1cf22ae011727ab1e40e55171/node_modules /root/.cache/trunk/tools/prettier/3.0.3-f40a31f1cf22ae011727ab1e40e55171/node_modules/.bin/prettier -w _includes/press_kit.html)
      affects_cache:
        []
      direct_configs:
        []
      exit_status: exited
      exit_code: 2
      stdout: (none)
      stderr: |
        [error] _includes/press_kit.html: SyntaxError: Unexpected closing tag "p". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags (9:9)
        [error]    7 |             

Press Kit

[error] 8 | [error] > 9 |

[error] | ^^^^ [error] 10 | [error] 11 |
[error] 12 |

Fact Sheet

parser: | (none)

Sandbox failed, so all sandbox checks will be disabled for this issue.

Install Sweep Configs: Pull Request

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/JimSellmeijer/raskal/blob/40df2798ee54d22f8bfd8a81409a1daee2ae3086/LICENCE#L1-L200 https://github.com/JimSellmeijer/raskal/blob/40df2798ee54d22f8bfd8a81409a1daee2ae3086/LICENCE#L155-L200 https://github.com/JimSellmeijer/raskal/blob/40df2798ee54d22f8bfd8a81409a1daee2ae3086/_includes/ekstase.html#L1-L32 https://github.com/JimSellmeijer/raskal/blob/40df2798ee54d22f8bfd8a81409a1daee2ae3086/_includes/press_kit.html#L103-L145 https://github.com/JimSellmeijer/raskal/blob/40df2798ee54d22f8bfd8a81409a1daee2ae3086/js/bootstrap.js#L1717-L1811

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/organize-website.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord