Closed GoogleCodeExporter closed 9 years ago
Done
Original comment by jason.schnitzler
on 23 Jun 2009 at 5:55
Hi Jason,
We have to tweak this further I think.
Donwload trailer from edit window button:
- When there is an existing local trailer, there should be a warning popup before
new trailer download, if the user want to overwrite the existing one
- When the existing trailer has an other extension, it should be deleted during the
download process. I tested with existing <movie>-trailer.mov trailer. After
downloaded a new trailer with one of the scraper, I had 2 different trailer
file. the
original <movie>-trailer.mov and a new <movie>-trailer.flv
Single re-scrape:
If you do a single re-scrape, EMM is asking to choose a trailer, even if you
have an
existing one(and overwrite trailers in unchecked).
Original comment by nadas.bence@gmail.com
on 24 Jun 2009 at 1:30
Original comment by nadas.bence@gmail.com
on 24 Jun 2009 at 1:33
Original comment by nadas.bence@gmail.com
on 25 Jun 2009 at 2:55
Original comment by nadas.bence@gmail.com
on 25 Jun 2009 at 3:09
Done for next release.... the single-scrape thing is a little tricky because
you also
have the option to just save it to nfo. So it's logic is like this:
If trailer does not exist or overwrite is enabled
OR
If nfo trailer is blank or lock trailer is disabled
then display dialog
So more than likely, it will pop up anyway. lol
There is now an option to delete all existing trailers, as well. When a trailer
download is successful, and the option is enabled, it will delete all other
trailer
files.
Original comment by jason.schnitzler
on 25 Jun 2009 at 8:20
Do you think deleting other trailers should be optional?
I think xbmc would be in trouble to decide which trailer to play if there is
more
trailer in the folder with different extensions.
Original comment by nadas.bence@gmail.com
on 25 Jun 2009 at 9:13
Yes definitely... ANY deleting of files should be optional, no matter what the
circumstances. In this case, YAMJ supports multiple trailers I believe....
people
would be pissed if we deleted all of them. lol
Original comment by jason.schnitzler
on 25 Jun 2009 at 10:21
hmmmmmm... This is something I would like to discuss further with you.
I am not comfortable with this solution.
My comments and concern:
- Why would one want to save the link to the nfo if he/she already has a local trailer?
- Concerning delete existing trailers. I think it would be more direct control to
not have an option for this, but have a popup confirmation during the download.
The
popup could have a choice whether to delete and overwrite existing trailer or
download the new one anyway.
Original comment by nadas.bence@gmail.com
on 26 Jun 2009 at 1:12
You set the link in the nfo (for people who don't want to download all these
trailer
files) OR download the file. ;)
It would get annoying to have to confirm to delete the files each time... thus
it's
in the settings. It's the same thing, you just only have to set it once and
forget it
when it's a setting vs a popup.
Original comment by jason.schnitzler
on 26 Jun 2009 at 7:01
Single rescrape issue has been fixed.
As per our discussion: Issue has been extended to handle multiple trailers and
their
overwrite algorythm.
We need to further discuss on this. In case we extend it to handle multiple
trailers,
then there is still too much veriety of using both overwrite and delete
trailers,
which can get confusing.
Original comment by nadas.bence@gmail.com
on 28 Jun 2009 at 6:54
Original comment by nadas.bence@gmail.com
on 29 Nov 2009 at 7:19
Original comment by nadas.bence@gmail.com
on 11 Dec 2009 at 7:19
Original issue reported on code.google.com by
nadas.bence@gmail.com
on 23 Jun 2009 at 4:49